linux-kernel - Re: [PATCH 2/2] leds: expresswire: don't depend on NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240215114831.GE9758@aspen.lan>
Date: Thu, 15 Feb 2024 11:48:31 +0000
From: Daniel Thompson <daniel.thompson@...aro.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Arnd Bergmann <arnd@...db.de>, Flavio Suligoi <f.suligoi@...m.it>,
	Hans de Goede <hdegoede@...hat.com>,
	Jianhua Lu <lujianhua000@...il.com>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Helge Deller <deller@....de>, Jingoo Han <jingoohan1@...il.com>,
	Karel Balej <balejk@...fyz.cz>, dri-devel@...ts.freedesktop.org,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH 2/2] leds: expresswire: don't depend on NEW_LEDS

On Mon, Feb 12, 2024 at 09:03:26PM +0100, Duje Mihanović wrote:
> The ExpressWire library does not depend on NEW_LEDS and selecting it
> from a subsystem other than LEDs may cause Kconfig warnings:
>
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
>   Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y]
>   Selected by [y]:
>   - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]
>
> Move it out of the "if NEW_LEDS" block to allow selection from other
> subsystems (in particular backlight) without raising this warning.
>
> Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Suggested-by: Daniel Thompson <daniel.thompson@...aro.org>
> Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library")
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>

Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>


Daniel.