linux-kernel - Re: [PATCH 1/2] Revert "leds: Only descend into leds directory when CONFIG_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 11:49:03 +0000
From: Daniel Thompson <daniel.thompson@...aro.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Arnd Bergmann <arnd@...db.de>, Flavio Suligoi <f.suligoi@...m.it>,
	Hans de Goede <hdegoede@...hat.com>,
	Jianhua Lu <lujianhua000@...il.com>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Helge Deller <deller@....de>, Jingoo Han <jingoohan1@...il.com>,
	Karel Balej <balejk@...fyz.cz>, dri-devel@...ts.freedesktop.org,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH 1/2] Revert "leds: Only descend into leds directory when
 CONFIG_NEW_LEDS is set"

On Mon, Feb 12, 2024 at 09:03:25PM +0100, Duje Mihanović wrote:
> This reverts commit b1ae40a5db6191c42e2e45d726407096f030ee08.
>
> The ExpressWire library introduced in 25ae5f5f4168 ("leds: Introduce
> ExpressWire library") does not depend on NEW_LEDS, but without this
> revert it would never get compiled if NEW_LEDS is not enabled. Revert
> this commit to allow the library to be compiled.
>
> Link: https://lore.kernel.org/2cacd8dc-6150-4aa2-af9e-830a202fb0a8@app.fastmail.com
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>

Interesting that this could be a revert!

Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>


Daniel.