linux-kernel - Re: [PATCH v2 1/3] PCI: qcom: reshuffle reset logic in 2_7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Feb 2024 12:51:38 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, linux-arm-msm@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH v2 1/3] PCI: qcom: reshuffle reset logic in 2_7_0 .init

On 12.02.2024 22:14, Bjorn Helgaas wrote:
> Would be nice to have a hint in the subject line about what this does.
> Also capitalize to match the others ("PCI: qcom: <Capitalized verb>").
> 
> On Sat, Feb 10, 2024 at 06:10:05PM +0100, Konrad Dybcio wrote:
>> At least on SC8280XP, if the PCIe reset is asserted, the corresponding
>> AUX_CLK will be stuck at 'off'. This has not been an issue so far,
>> since the reset is both left de-asserted by the previous boot stages
>> and the driver only toggles it briefly in .init.
>>
>> As part of the upcoming suspend prodecure however, the reset will be
>> held asserted.
> 
> s/prodecure/procedure/

Before I get around to resending, does the commit look fine otherwise?

Konrad