linux-kernel - Re: [PATCH v12 04/25] genirq/irqdomain: Add DOMAIN_BUS_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86o7ci3puk.wl-maz@kernel.org>
Date: Thu, 15 Feb 2024 11:54:11 +0000
From: Marc Zyngier <maz@...nel.org>
To: Anup Patel <apatel@...tanamicro.com>
Cc: Palmer Dabbelt <palmer@...belt.com>,	Paul Walmsley
 <paul.walmsley@...ive.com>,	Thomas Gleixner <tglx@...utronix.de>,	Rob
 Herring <robh+dt@...nel.org>,	Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>,	Frank Rowand <frowand.list@...il.com>,
	Conor Dooley <conor+dt@...nel.org>,	Björn Töpel
 <bjorn@...nel.org>,	Atish Patra <atishp@...shpatra.org>,	Andrew Jones
 <ajones@...tanamicro.com>,	Sunil V L <sunilvl@...tanamicro.com>,	Saravana
 Kannan <saravanak@...gle.com>,	Anup Patel <anup@...infault.org>,
	linux-riscv@...ts.infradead.org,	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,	devicetree@...r.kernel.org
Subject: Re: [PATCH v12 04/25] genirq/irqdomain: Add DOMAIN_BUS_DEVICE_IMS

On Sat, 27 Jan 2024 16:17:32 +0000,
Anup Patel <apatel@...tanamicro.com> wrote:
> 
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> Add a new domain bus token to prepare for device MSI which aims to replace
> the existing platform MSI maze.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Anup Patel <apatel@...tanamicro.com>
> ---
>  include/linux/irqdomain_defs.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/irqdomain_defs.h b/include/linux/irqdomain_defs.h
> index c29921fd8cd1..4c69151cb9d2 100644
> --- a/include/linux/irqdomain_defs.h
> +++ b/include/linux/irqdomain_defs.h
> @@ -26,6 +26,7 @@ enum irq_domain_bus_token {
>  	DOMAIN_BUS_DMAR,
>  	DOMAIN_BUS_AMDVI,
>  	DOMAIN_BUS_PCI_DEVICE_IMS,
> +	DOMAIN_BUS_DEVICE_IMS,

Only a personal taste, but since we keep calling it "device MSI",
which it really is, I find it slightly odd to name the token
"DEVICE_IMS".

From what I understand, IMS is PCIe specific. Platform (and by
extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI
would make a lot more sense and avoid confusion.

But hey, I don't have much skin in this game, and I can probably
mentally rotate the acronym...

	M.

-- 
Without deviation from the norm, progress is not possible.