linux-kernel - Re: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_MCQX+vP9aGsYdKejQtPF=rgKqNauDwqCLa39Ug8Nd-zg@mail.gmail.com>
Date: Fri, 16 Feb 2024 11:59:42 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@....com>, 
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>, Daniel Vetter <daniel@...ll.ch>, 
	David Airlie <airlied@...il.com>, 
	Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, Jason Gunthorpe <jgg@...pe.ca>, 
	Leon Romanovsky <leon@...nel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "Pan, Xinhui" <Xinhui.Pan@....com>, 
	"Koenig, Christian" <Christian.Koenig@....com>, Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

Applied.  Thanks.

Alex

On Fri, Feb 16, 2024 at 5:38 AM Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com> wrote:
>
> On Thu, 15 Feb 2024, Deucher, Alexander wrote:
>
> > [Public]
> >
> > > -----Original Message-----
> > > From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > > Sent: Thursday, February 15, 2024 8:32 AM
> > > To: Deucher, Alexander <Alexander.Deucher@....com>; amd-
> > > gfx@...ts.freedesktop.org; Daniel Vetter <daniel@...ll.ch>; David Airlie
> > > <airlied@...il.com>; Dennis Dalessandro
> > > <dennis.dalessandro@...nelisnetworks.com>; dri-
> > > devel@...ts.freedesktop.org; Jason Gunthorpe <jgg@...pe.ca>; Leon
> > > Romanovsky <leon@...nel.org>; linux-kernel@...r.kernel.org; linux-
> > > rdma@...r.kernel.org; Pan, Xinhui <Xinhui.Pan@....com>; Koenig, Christian
> > > <Christian.Koenig@....com>
> > > Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>; Lukas Wunner
> > > <lukas@...ner.de>
> > > Subject: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2
> > >
> > > Convert open coded RMW accesses for LNKCTL2 to use
> > > pcie_capability_clear_and_set_word() which makes its easier to understand
> > > what the code tries to do.
> > >
> > > LNKCTL2 is not really owned by any driver because it is a collection of control
> > > bits that PCI core might need to touch. RMW accessors already have support
> > > for proper locking for a selected set of registers
> > > (LNKCTL2 is not yet among them but likely will be in the future) to avoid losing
> > > concurrent updates.
> > >
> > > Suggested-by: Lukas Wunner <lukas@...ner.de>
> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> >
> > The radeon and amdgpu patches are:
> > Acked-by: Alex Deucher <alexander.deucher@....com>
> >
> > Are you looking for me to pick them up or do you want to land them as
> > part of some larger change?  Either way is fine with me.
>
> Hi,
>
> You please take them, I intentionally took them apart from the BW
> controller series so they can go through the usual trees, not along with
> the BW controller. (I don't expect the BW controller to be accepted during
> this cycle).
>
> --
>  i.