linux-kernel - Re: [PATCH] powerpc: remove unused *_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARFNoAUUiGMP95pTi_rSxSi5Z0HJo2kBC472f0koMr2mA@mail.gmail.com>
Date: Sat, 17 Feb 2024 10:06:56 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, 
	Christophe Leroy <christophe.leroy@...roup.eu>, 
	"Aneesh Kumar K . V" <aneesh.kumar@...nel.org>, "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>, 
	linuxppc-dev@...ts.ozlabs.org, Daniel Axtens <dja@...ens.net>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: remove unused *_syscall_64.o variables in Makefile

+To: Daniel Axtens



Maybe, we should check if the issue fixed by
2f26ed1764b42a8c40d9c48441c73a70d805decf
came back.





On Fri, Feb 16, 2024 at 10:55 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Commit ab1a517d55b0 ("powerpc/syscall: Rename syscall_64.c into
> interrupt.c") missed to update these three lines:
>
>   GCOV_PROFILE_syscall_64.o := n
>   KCOV_INSTRUMENT_syscall_64.o := n
>   UBSAN_SANITIZE_syscall_64.o := n
>
> To restore the original behavior, we could replace them with:
>
>   GCOV_PROFILE_interrupt.o := n
>   KCOV_INSTRUMENT_interrupt.o := n
>   UBSAN_SANITIZE_interrupt.o := n
>
> However, nobody has noticed the functional change in the past three
> years, so they were unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  arch/powerpc/kernel/Makefile | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
> index 2919433be355..72d1cd6443bc 100644
> --- a/arch/powerpc/kernel/Makefile
> +++ b/arch/powerpc/kernel/Makefile
> @@ -191,9 +191,6 @@ GCOV_PROFILE_kprobes-ftrace.o := n
>  KCOV_INSTRUMENT_kprobes-ftrace.o := n
>  KCSAN_SANITIZE_kprobes-ftrace.o := n
>  UBSAN_SANITIZE_kprobes-ftrace.o := n
> -GCOV_PROFILE_syscall_64.o := n
> -KCOV_INSTRUMENT_syscall_64.o := n
> -UBSAN_SANITIZE_syscall_64.o := n
>  UBSAN_SANITIZE_vdso.o := n
>
>  # Necessary for booting with kcov enabled on book3e machines
> --
> 2.40.1
>


-- 
Best Regards
Masahiro Yamada