linux-kernel - Re: [PATCH] powerpc: remove unused *_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874je31yhv.fsf@mail.lhotse>
Date: Tue, 20 Feb 2024 16:43:56 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Masahiro Yamada <masahiroy@...nel.org>, Nicholas Piggin
 <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 "Aneesh Kumar K . V" <aneesh.kumar@...nel.org>, "Naveen N . Rao"
 <naveen.n.rao@...ux.ibm.com>, linuxppc-dev@...ts.ozlabs.org, Daniel Axtens
 <dja@...ens.net>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: remove unused *_syscall_64.o variables in
 Makefile

Masahiro Yamada <masahiroy@...nel.org> writes:
> +To: Daniel Axtens

Unfortunately dja doesn't work on the kernel anymore.

> Maybe, we should check if the issue fixed by
> 2f26ed1764b42a8c40d9c48441c73a70d805decf
> came back.

That crash is specific to Power8, which probably no one is running
syzkaller on anymore.

If I enable KCOV and boot with 1T segments disabled (to make it easier
to trigger the bug) it crashes similarly to the report in that commit.

> On Fri, Feb 16, 2024 at 10:55 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
..
>> To restore the original behavior, we could replace them with:
>>
>>   GCOV_PROFILE_interrupt.o := n
>>   KCOV_INSTRUMENT_interrupt.o := n
>>   UBSAN_SANITIZE_interrupt.o := n

But just putting those back isn't actually enough to fix it, the code
has changed and there are other places that need KCOV disabled on P8.

So I'm not sure how to handle this one. I guess I might just take it and
then make a todo to fix the KCOV problems later.

cheers