linux-kernel - Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024021739-self-pencil-b932@gregkh>
Date: Sat, 17 Feb 2024 16:32:54 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ondřej Jirman <megi@....cz>
Cc: linux-usb@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into
 unattached state after try role"

On Thu, Feb 15, 2024 at 08:33:50PM +0100, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@....cz>
> 
> The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
> to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
> after initially trying SNK_TRY earlier, as it should for toggling to ever detect
> the power source mode and the port is again able to provide power to attached
> power sinks.
> 
> This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.
> ---
>  drivers/usb/typec/tcpm/tcpm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
> for more.
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index f7d7daa60c8d..295ae7eb912c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
>  	if (tcpm_port_is_disconnected(port))
>  		port->hard_reset_count = 0;
>  
> -	port->try_src_count = 0;
> -	port->try_snk_count = 0;
> -
>  	if (!port->attached)
>  		return;
>  
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot