[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e1f56317-b70d-0b81-75f0-fef50616e026@collabora.com>
Date: Mon, 19 Feb 2024 14:22:41 +0530
From: Vignesh Raman <vignesh.raman@...labora.com>
To: Maíra Canal <mcanal@...lia.com>,
dri-devel@...ts.freedesktop.org
Cc: linux-rockchip@...ts.infradead.org, guilherme.gallo@...labora.com,
sergi.blanch.torne@...labora.com, linux-kernel@...r.kernel.org,
david.heidelberg@...labora.com, helen.koike@...labora.com,
linux-mediatek@...ts.infradead.org, amd-gfx@...ts.freedesktop.org,
daniel@...ll.ch, linux-amlogic@...ts.infradead.org, airlied@...il.com
Subject: Re: [PATCH v3 9/9] drm/ci: uprev IGT and update testlist
Hi Maíra,
On 10/02/24 23:50, Maíra Canal wrote:
> On 2/10/24 15:17, Maíra Canal wrote:
>> On 1/30/24 12:03, Vignesh Raman wrote:
>>> Uprev IGT and add amd, v3d, vc4 and vgem specific
>>> tests to testlist. Have testlist.txt per driver
>>> and include a base testlist so that the driver
>>> specific tests will run only on those hardware.
>>>
>>> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
>>> ---
>>>
>>> v3:
>>> - New patch in series to uprev IGT and update testlist.
>>>
>>> ---
>>> drivers/gpu/drm/ci/gitlab-ci.yml | 2 +-
>>> drivers/gpu/drm/ci/igt_runner.sh | 12 +-
>>> drivers/gpu/drm/ci/testlist-amdgpu.txt | 151 ++++++++++++++++++
>>> drivers/gpu/drm/ci/testlist-msm.txt | 50 ++++++
>>> drivers/gpu/drm/ci/testlist-panfrost.txt | 17 ++
>>> drivers/gpu/drm/ci/testlist-v3d.txt | 73 +++++++++
>>> drivers/gpu/drm/ci/testlist-vc4.txt | 49 ++++++
>>> drivers/gpu/drm/ci/testlist.txt | 100 ++++--------
>>> .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 24 ++-
>>> .../drm/ci/xfails/amdgpu-stoney-flakes.txt | 9 +-
>>> .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 10 +-
>>> 11 files changed, 427 insertions(+), 70 deletions(-)
>>> create mode 100644 drivers/gpu/drm/ci/testlist-amdgpu.txt
>>> create mode 100644 drivers/gpu/drm/ci/testlist-msm.txt
>>> create mode 100644 drivers/gpu/drm/ci/testlist-panfrost.txt
>>> create mode 100644 drivers/gpu/drm/ci/testlist-v3d.txt
>>> create mode 100644 drivers/gpu/drm/ci/testlist-vc4.txt
>>>
>>> diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml
>>> b/drivers/gpu/drm/ci/gitlab-ci.yml
>>> index bc8cb3420476..e2b021616a8e 100644
>>> --- a/drivers/gpu/drm/ci/gitlab-ci.yml
>>> +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
>>> @@ -5,7 +5,7 @@ variables:
>>> UPSTREAM_REPO: git://anongit.freedesktop.org/drm/drm
>>> TARGET_BRANCH: drm-next
>>> - IGT_VERSION: d2af13d9f5be5ce23d996e4afd3e45990f5ab977
>>> + IGT_VERSION: b0cc8160ebdc87ce08b7fd83bb3c99ff7a4d8610
>>> DEQP_RUNNER_GIT_URL:
>>> https://gitlab.freedesktop.org/anholt/deqp-runner.git
>>> DEQP_RUNNER_GIT_TAG: v0.15.0
>>> diff --git a/drivers/gpu/drm/ci/igt_runner.sh
>>> b/drivers/gpu/drm/ci/igt_runner.sh
>>> index f001e015d135..2fd09b9b7cf6 100755
>>> --- a/drivers/gpu/drm/ci/igt_runner.sh
>>> +++ b/drivers/gpu/drm/ci/igt_runner.sh
>>> @@ -64,10 +64,20 @@ if ! grep -q "core_getversion"
>>> /install/testlist.txt; then
>>> fi
>>> set +e
>>> +if [ "$DRIVER_NAME" = "amdgpu" ]; then
>>> + TEST_LIST="/install/testlist-amdgpu.txt"
>>> +elif [ "$DRIVER_NAME" = "msm" ]; then
>>> + TEST_LIST="/install/testlist-msm.txt"
>>> +elif [ "$DRIVER_NAME" = "panfrost" ]; then
>>> + TEST_LIST="/install/testlist-panfrost.txt"
>>> +else
>>> + TEST_LIST="/install/testlist.txt"
>>> +fi
>>> +
>>
>> Isn't V3D and VC4 testlists missing?
Yes. We need to add ci jobs to test v3d/vc4. The initial idea was just
to split the testlist per driver and add vc4/v3d tests so that it can be
used in future. I will add the jobs as part of v4.
>> It would be nice if you could provide us a link to a working pipeline.
Will provide the working pipeline link in next series.
>> Also, if possible, I would like to be CCed on the next version of this
>> patch, as I have interest in the V3D/VC4 tests.
Sure, will do.
> Ah, one thing: it would be nice to add the testlists to the MAINTAINERS
> file. This way, maintainers can keep track of any changes.
Yes, will add the testlists to MAINTAINERS file.
Thanks for the review and feedback.
Regards,
Vignesh
Powered by blists - more mailing lists