linux-kernel - Re: [PATCH 0/7] riscv: Various text patching improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87msrwfxpa.fsf@all.your.base.are.belong.to.us>
Date: Mon, 19 Feb 2024 13:25:05 +0100
From: Björn Töpel <bjorn@...nel.org>
To: Andrea Parri <parri.andrea@...il.com>, Samuel Holland
 <samuel.holland@...ive.com>
Cc: Palmer Dabbelt <palmer@...belt.com>, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Jason Baron <jbaron@...mai.com>, Josh
 Poimboeuf <jpoimboe@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Steven Rostedt <rostedt@...dmis.org>, bpf@...r.kernel.org, Alexandre Ghiti
 <alexghiti@...osinc.com>, Björn Töpel
 <bjorn@...osinc.com>
Subject: Re: [PATCH 0/7] riscv: Various text patching improvements

Andrea Parri <parri.andrea@...il.com> writes:

> Hi Samuel,
>
> On Sun, Feb 11, 2024 at 06:55:11PM -0800, Samuel Holland wrote:
>> Here are a few changes to minimize calls to stop_machine() and
>> flush_icache_*() in the various text patching functions, as well as
>> to simplify the code.
>> 
>> 
>> Samuel Holland (7):
>>   riscv: jump_label: Batch icache maintenance
>>   riscv: jump_label: Simplify assembly syntax
>>   riscv: kprobes: Use patch_text_nosync() for insn slots
>>   riscv: Simplify text patching loops
>>   riscv: Pass patch_text() the length in bytes
>>   riscv: Use offset_in_page() in text patching functions
>>   riscv: Remove extra variable in patch_text_nosync()
>
> This does look like a nice clean-up.  Just curious (a "teach me"-like question),
> how did you test these changes? kselftests, micro-benchmarks, other?
>
> BTW, I recall a parallel work from Alex and Bjorn [1] that might have some minor
> conflict with these changes; + both of them to Cc: for further sync.

Indeed! I think Alex is still working on the v2.