linux-kernel - Re: [PATCH 00/10] vdso: Misc cleanups and prevent code duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 14:48:34 +0000
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>,
 linux-kernel@...r.kernel.org
Cc: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 00/10] vdso: Misc cleanups and prevent code duplication



On 19/02/2024 15:39, Anna-Maria Behnsen wrote:
> Hi,
> 
> the vdso related cleanup queue contains two parts:
> 
> - Patch 1-3: Misc cleanups related to a comment, a superfluous header
> 	     include and ifdeffery
> 
> - Patch 4-10: The union vdso_data_store is defined in seven
>   	      architectures. Make this union available in a generic vdso
>   	      header file to prevent code duplication and fix the
>   	      architectures one by one to use the generic vdso_data_store.
> 
> Thanks,
> 
> 	Anna-Maria
> 
> 

Really good cleanup. Thank you for this.

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> Anna-Maria Behnsen (10):
>   vdso/helpers: Fix grammar in comments
>   s390/vdso/data: Drop unnecessary header include
>   csky/vdso: Remove superfluous ifdeffery
>   vdso/arm: make union vdso_data_store available for all
>   arm64/vdso: Use generic union vdso_data_store
>   riscv/vdso: Use generic union vdso_data_store
>   s390/vdso: Use generic union vdso_data_store
>   loongarch/vdso: Use generic union vdso_data_store
>   mips/vdso: Use generic union vdso_data_store
>   csky/vdso: Use generic union vdso_data_store
> 
>  arch/arm/include/asm/elf.h           |  1 -
>  arch/arm/include/asm/vdso_datapage.h | 26 --------------------------
>  arch/arm/kernel/asm-offsets.c        |  4 +++-
>  arch/arm/kernel/vdso.c               |  4 ----
>  arch/arm64/kernel/vdso.c             |  5 +----
>  arch/csky/include/asm/vdso.h         |  5 -----
>  arch/csky/kernel/vdso.c              | 14 ++------------
>  arch/loongarch/kernel/vdso.c         |  6 ++----
>  arch/mips/include/asm/vdso.h         |  5 -----
>  arch/mips/kernel/vdso.c              |  2 +-
>  arch/riscv/kernel/vdso.c             |  8 +-------
>  arch/s390/include/asm/vdso/data.h    |  1 -
>  arch/s390/kernel/vdso.c              |  5 +----
>  include/vdso/datapage.h              | 10 ++++++++++
>  include/vdso/helpers.h               |  8 ++++----
>  15 files changed, 25 insertions(+), 79 deletions(-)
>  delete mode 100644 arch/arm/include/asm/vdso_datapage.h
> 

-- 
Regards,
Vincenzo