linux-kernel - Re: [PATCH 00/10] vdso: Misc cleanups and prevent code duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 10:50:48 +0100
From: Anna-Maria Behnsen <anna-maria@...utronix.de>
To: Kees Cook <keescook@...omium.org>
Cc: linux-kernel@...r.kernel.org, Andy Lutomirski <luto@...nel.org>, Thomas
 Gleixner <tglx@...utronix.de>, Vincenzo Frascino
 <vincenzo.frascino@....com>
Subject: Re: [PATCH 00/10] vdso: Misc cleanups and prevent code duplication

Kees Cook <keescook@...omium.org> writes:

> On Mon, Feb 19, 2024 at 04:39:29PM +0100, Anna-Maria Behnsen wrote:
>> Hi,
>> 
>> the vdso related cleanup queue contains two parts:
>> 
>> - Patch 1-3: Misc cleanups related to a comment, a superfluous header
>> 	     include and ifdeffery
>> 
>> - Patch 4-10: The union vdso_data_store is defined in seven
>>   	      architectures. Make this union available in a generic vdso
>>   	      header file to prevent code duplication and fix the
>>   	      architectures one by one to use the generic vdso_data_store.
>> 
>> Thanks,
>> 
>> 	Anna-Maria
>
> I do love a good clean-up! Thanks for this, I looked through all the
> patches and they seem correct to me;

Thank you! I had a mistake in there and already posted a new version for
this single patch - I forgot to update this patch before posting...

> removed definitions are all
> identical, and __page_aligned_data is kept where needed.
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>
> -Kees

Thanks,

	Anna-Maria