linux-kernel - Re: [PATCH v10 00/14] PCI: imx6: Clean up and add imx95 pci support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdR2FRQ9Fe8hhK9I@x1-carbon>
Date: Tue, 20 Feb 2024 10:51:17 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	lpieralisi@...nel.org, bhelgaas@...gle.com, conor+dt@...nel.org,
	devicetree@...r.kernel.org, festevam@...il.com, helgaas@...nel.org,
	hongxing.zhu@....com, imx@...ts.linux.dev, kernel@...gutronix.de,
	krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org,
	kw@...ux.com, l.stach@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	robh@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v10 00/14] PCI: imx6: Clean up and add imx95 pci support

On Mon, Feb 19, 2024 at 11:18:03AM -0500, Frank Li wrote:
> On Mon, Feb 19, 2024 at 09:42:08PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, Feb 19, 2024 at 10:11:45AM -0500, Frank Li wrote:
> > > On Mon, Feb 05, 2024 at 12:33:21PM -0500, Frank Li wrote:
> > > > first 6 patches use drvdata: flags to simplify some switch-case code.
> > > > Improve maintaince and easy to read code.
> > > > 
> > > 
> > > @Lorenzo Pieralisi:
> > > 
> > > 	Do you have chance to look other patches?
> > > 	Mani's apply EP side change. 
> > 
> > Even though the controller is for the endpoint, it is still a controller
> > driver. So all the patches should go through Lorenzo.
> > 
> > I only merge patches under drivers/pci/endpoint. Hope this clarifies.
> 
> Sorry. It confused everyone. My means was that Mani applied Niklas Cassel's
> patches, which cause my 14th patch build failure.

Hello Frank,

Patch 14, which adds this:

+static const struct pci_epc_features imx95_pcie_epc_features = {
+       .msi_capable = true,
+       .bar_fixed_size[1] = SZ_64K,
+       .align = SZ_4K,
+};


Should, after rebasing on Mani's pci/endpoint branch, instead look like this:

+static const struct pci_epc_features imx95_pcie_epc_features = {
+       .msi_capable = true,
+       .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_64K, },
+       .align = SZ_4K,
+};


> 
> I asked if I need update my 14th patch or applied 1-13 only. 

I see, you want the maintainers to apply 1-13, and simply drop patch 14
instead of you sending out a rebased series.

I assume that the maintainers will be fine with your suggested approach.


Kind regards,
Niklas