linux-kernel - Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9281dd01-d20e-4eed-96ae-6aa63c9eb678@roeck-us.net>
Date: Tue, 20 Feb 2024 11:42:18 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>,
 antoniu.miclaus@...log.com, alexandre.belloni@...tlin.com,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 jdelvare@...e.com
Cc: linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
 Zeynep Arslanbenzer <Zeynep.Arslanbenzer@...log.com>
Subject: Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver

On 2/19/24 14:18, Chris Packham wrote:
> From: Ibrahim Tilki <Ibrahim.Tilki@...log.com>
> 
> Adding support for Analog Devices MAX313XX series RTCs.
> 

Adding -> Add

The subject should really be something like "rtc: max31335: Add support
for additional chips", with details in the patch description.

All those (in my opinion unnecessary) function, data structure,
and variable renames makes it really difficult to review the code.
I don't see the point of that, so please don't expect any further
feedback about the hwmon changes from me.

Thanks,
Guenter