linux-kernel - Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08d0ac81-8e14-459d-a71e-34392d833371@alliedtelesis.co.nz>
Date: Tue, 20 Feb 2024 20:07:27 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Guenter Roeck <linux@...ck-us.net>, "antoniu.miclaus@...log.com"
	<antoniu.miclaus@...log.com>, "alexandre.belloni@...tlin.com"
	<alexandre.belloni@...tlin.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "jdelvare@...e.com"
	<jdelvare@...e.com>
CC: "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>, "Zeynep
 Arslanbenzer" <Zeynep.Arslanbenzer@...log.com>
Subject: Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver

On 21/02/24 08:42, Guenter Roeck wrote:
> On 2/19/24 14:18, Chris Packham wrote:
>> From: Ibrahim Tilki <Ibrahim.Tilki@...log.com>
>>
>> Adding support for Analog Devices MAX313XX series RTCs.
>>
>
> Adding -> Add
>
> The subject should really be something like "rtc: max31335: Add support
> for additional chips", with details in the patch description.

Ack.

> All those (in my opinion unnecessary) function, data structure,
> and variable renames makes it really difficult to review the code.
> I don't see the point of that, so please don't expect any further
> feedback about the hwmon changes from me. 

Sorry about that. In reality what happened is that someone started 
trying to add support for the range then they left Analog Devices with 
the patch still in flight. In the mean time someone else from AD landed 
a driver for a single variant (with no public datasheet). I'm left 
trying to pick up the pieces.

This is effectively the original max313xx series patch with the max31335 
changes incorporated as best I can. I can probably rename more things so 
there is less delta against the max31335 driver.

> Thanks,
> Guenter
>