linux-kernel - Re: [PATCH v2 4/7] mmc: sdhci_am654: Fix itapdly/otapdly array type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <954f09c0-9486-4830-a8ae-c5172f74bdc7@ti.com>
Date: Tue, 20 Feb 2024 14:14:07 -0600
From: Judith Mendez <jm@...com>
To: Adrian Hunter <adrian.hunter@...el.com>
CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ulf Hansson
	<ulf.hansson@...aro.org>
Subject: Re: [PATCH v2 4/7] mmc: sdhci_am654: Fix itapdly/otapdly array type

Hi Adrian,

On 2/16/24 11:10 AM, Adrian Hunter wrote:
> On 7/02/24 03:15, Judith Mendez wrote:
>> While integer type works, the otap_del_sel and itap_del_sel
>> arrays are manipulated as u32, so change array types to u32.
> 
> If it doesn't make any practical difference, then it is not
> generally considered a "fix", at least according to stable
> kernel rules, so Fixes tags are probably not warranted here.

Understood, will remove fixes tag here then, thanks.

> 
>>
>> Fixes: 8ee5fc0e0b3b ("mmc: sdhci_am654: Update OTAPDLY writes")
>> Fixes: a0a62497f6aa ("mmc: sdhci_am654: Add support for input tap delay")
>> Signed-off-by: Judith Mendez <jm@...com>
>> ---
>>   drivers/mmc/host/sdhci_am654.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
>> index 935f581c05d8..35ba7d921690 100644
>> --- a/drivers/mmc/host/sdhci_am654.c
>> +++ b/drivers/mmc/host/sdhci_am654.c
>> @@ -141,8 +141,8 @@ static const struct timing_data td[] = {
>>   
>>   struct sdhci_am654_data {
>>   	struct regmap *base;
>> -	int otap_del_sel[ARRAY_SIZE(td)];
>> -	int itap_del_sel[ARRAY_SIZE(td)];
>> +	u32 otap_del_sel[ARRAY_SIZE(td)];
>> +	u32 itap_del_sel[ARRAY_SIZE(td)];
>>   	u32 itap_del_ena[ARRAY_SIZE(td)];
>>   	int clkbuf_sel;
>>   	int trm_icp;
> 

~ Judith