lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20c93f08-b583-4cb1-98a1-86dd4313e693@ti.com>
Date: Tue, 20 Feb 2024 14:14:44 -0600
From: Judith Mendez <jm@...com>
To: Adrian Hunter <adrian.hunter@...el.com>
CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ulf Hansson
	<ulf.hansson@...aro.org>
Subject: Re: [PATCH v2 5/7] mmc: sdhci_am654: Update comments in
 sdhci_am654_set_clock

Hi Adrian,

On 2/16/24 11:11 AM, Adrian Hunter wrote:
> On 7/02/24 03:15, Judith Mendez wrote:
>> The sdhci_am654_set_clock function is also used to enable
>> delay chain, therefore fix comments to be more generic in
>> case we are not enabling DLL.
>>
>> Fixes: fe52e2fbc6ef ("mmc: sdhci_am654: Fix conditions for enabling dll")
> 
> Similar to patch 4, Fixes tag is probably not warranted.

Will fix for V3, thanks.

> 
>> Signed-off-by: Judith Mendez <jm@...com>
>> ---
>>   drivers/mmc/host/sdhci_am654.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
>> index 35ba7d921690..3755a015f328 100644
>> --- a/drivers/mmc/host/sdhci_am654.c
>> +++ b/drivers/mmc/host/sdhci_am654.c
>> @@ -279,7 +279,7 @@ static void sdhci_am654_set_clock(struct sdhci_host *host, unsigned int clock)
>>   
>>   	sdhci_set_clock(host, clock);
>>   
>> -	/* Setup DLL Output TAP delay */
>> +	/* Setup Output TAP delay */
>>   	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>>   
>>   	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
>> @@ -322,7 +322,7 @@ static void sdhci_j721e_4bit_set_clock(struct sdhci_host *host,
>>   	u32 itap_del_ena;
>>   	u32 mask, val;
>>   
>> -	/* Setup DLL Output TAP delay */
>> +	/* Setup Output TAP delay */
>>   	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>>   
>>   	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
> 

~ Judith

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ