linux-kernel - Re: [PATCH] tools: selftests: Remove unnecessary semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 16:48:23 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thorsten Blum <thorsten.blum@...lux.com>, Shuah Khan <shuah@...nel.org>
Cc: Mykola Lysenko <mykolal@...com>, Martin KaFai Lau <martin.lau@...ux.dev>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] tools: selftests: Remove unnecessary semicolons

On 2/13/24 05:23, Thorsten Blum wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>   tools/testing/selftests/bpf/benchs/bench_local_storage_create.c | 2 +-
>   tools/testing/selftests/kvm/access_tracking_perf_test.c         | 2 +-
>   tools/testing/selftests/timers/nanosleep.c                      | 2 +-
>   tools/testing/selftests/timers/nsleep-lat.c                     | 2 +-
>   tools/testing/selftests/timers/set-timer-lat.c                  | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 

Thank you for finding the problems and fixing them.

Please split these up and generate separate patches.
Run getmaintainers.pl to get the right people to send the
patch.

Taking all these changes in one single patch will result in
conflicts between the trees and more importantly if changes
to one file have to reverted for some reason, it makes it
easier have separate patches.

thanks,
-- Shuah