linux-kernel - Re: [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN happens"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f51946e2-68f4-4368-9a77-050382dfa3ff@kernel.org>
Date: Tue, 20 Feb 2024 14:50:11 +0800
From: Chao Yu <chao@...nel.org>
To: Wu Bo <wubo.oduw@...il.com>, Wu Bo <bo.wu@...o.com>,
 Jaegeuk Kim <jaegeuk@...nel.org>
Cc: linux-f2fs-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN
 happens"

On 2024/2/8 16:11, Wu Bo wrote:
> On 2024/2/5 11:54, Chao Yu wrote:
>> How about calling f2fs_balance_fs() to double check and make sure there is
>> enough free space for following allocation.
>>
>>         if (has_not_enough_free_secs(sbi, 0,
>>             GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi)))) {
>>             f2fs_down_write(&sbi->gc_lock);
>>             stat_inc_gc_call_count(sbi, FOREGROUND);
>>             err = f2fs_gc(sbi, &gc_control);
>>             if (err == -EAGAIN)
>>                 f2fs_balance_fs(sbi, true);
>>             if (err && err != -ENODATA)
>>                 goto out_err;
>>         }
>>
>> Thanks,
> 
> f2fs_balance_fs() here will not change procedure branch and may just trigger another GC.
> 
> I'm afraid this is a bit redundant.

Okay.

I guess maybe Jaegeuk has concern which is the reason to commit
2e42b7f817ac ("f2fs: stop allocating pinned sections if EAGAIN happens").

Thanks,

> 
>>