linux-kernel - Re: [PATCH] sparc: Fix undefined reference to fb_is_primary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h6i3ii87.fsf@minerva.mail-host-address-is-not-set>
Date: Tue, 20 Feb 2024 10:43:20 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, linux-kernel@...r.kernel.org
Cc: kernel test robot <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
 Andreas Larsson <andreas@...sler.com>, Arnd Bergmann <arnd@...db.de>,
 "David S. Miller" <davem@...emloft.net>, Helge Deller <deller@....de>,
 sparclinux@...r.kernel.org
Subject: Re: [PATCH] sparc: Fix undefined reference to fb_is_primary_device

Thomas Zimmermann <tzimmermann@...e.de> writes:

Hello Thomas,

> Hi
>
> Am 20.02.24 um 01:34 schrieb Javier Martinez Canillas:
>> Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE
>> symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only
>> have fbcon/VT and DRM fbdev emulation, but without support for any legacy
>> fbdev driver.
>>
>> Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and
>> that leads to the following linking error in some sparc64 configurations:
>>
>>     sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered':
>>>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device'
>> Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/
>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>> ---
>>
>> I don't have a sparc64 toolchain to test this patch, but I'm pretty sure
>> that this is the correct fix for the linking error reported by the robot.
>>
>>   arch/sparc/video/Makefile | 2 +-
>
> I think you also have to fix arch/sparc/Makefile.
>

Oh, you are right! Thanks for pointing that.

> Best regards
> Thomas
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat