linux-kernel - Re: [PATCH v1 1/3] dt-bindings: PCI: qcom: Add global irq support for SA8775p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0677780-d013-44f7-94bf-ea7e23aab019@linaro.org>
Date: Wed, 21 Feb 2024 15:31:36 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 root <root@...msarkar-hyd.qualcomm.com>, andersson@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, jingoohan1@...il.com,
 gustavo.pimentel@...opsys.com, manivannan.sadhasivam@...aro.org,
 conor+dt@...nel.org, quic_nitegupt@...cinc.com
Cc: quic_shazhuss@...cinc.com, quic_ramkri@...cinc.com,
 quic_nayiluri@...cinc.com, quic_krichai@...cinc.com,
 quic_vbadigan@...cinc.com, Mrinmay Sarkar <quic_msarkar@...cinc.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: qcom: Add global irq support for
 SA8775p

On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
> On 21/02/2024 15:04, root wrote:
>> From: Mrinmay Sarkar <quic_msarkar@...cinc.com>
>>
>> Add global interrupt support in dt-bindings for SA8775p RC platform.
> 
> What is this global interrupt? Why wasn't it there before?
> 
>>
>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@...cinc.com>
>> ---
>>  .../devicetree/bindings/pci/qcom,pcie.yaml    | 26 +++++++++++++++++--
>>  1 file changed, 24 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> index a93ab3b54066..d86fb63a2d2c 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> @@ -63,7 +63,7 @@ properties:
>>  
>>    interrupt-names:
>>      minItems: 1
>> -    maxItems: 8
>> +    maxItems: 9
>>  
>>    iommu-map:
>>      minItems: 1
>> @@ -873,8 +873,30 @@ allOf:
>>          compatible:
>>            contains:
>>              enum:
>> -              - qcom,pcie-msm8996
>>                - qcom,pcie-sa8775p
>> +    then:
>> +      oneOf:
> 
> No need, drop.

Moreover, I think this global irq should be present on all qc platforms

Konrad