linux-kernel - Re: [PATCH v1 3/3] PCI: qcom: Add support for detecting controller level PCIe errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 15:35:22 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: root <root@...msarkar-hyd.qualcomm.com>, andersson@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, jingoohan1@...il.com,
 gustavo.pimentel@...opsys.com, konrad.dybcio@...aro.org,
 manivannan.sadhasivam@...aro.org, conor+dt@...nel.org,
 quic_nitegupt@...cinc.com
Cc: quic_shazhuss@...cinc.com, quic_ramkri@...cinc.com,
 quic_nayiluri@...cinc.com, quic_krichai@...cinc.com,
 quic_vbadigan@...cinc.com, Nitesh Gupta <nitegupt@...cinc.com>,
 Mrinmay Sarkar <quic_msarkar@...cinc.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Rob Herring <robh@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] PCI: qcom: Add support for detecting controller
 level PCIe errors

On 21/02/2024 15:04, root wrote:
> From: Nitesh Gupta <nitegupt@...cinc.com>
> 
> Synopsys Controllers provide capabilities to detect various controller
> level errors. These can range from controller interface error to random
> PCIe configuration errors. This patch intends to add support to detect
> these errors and report it to userspace entity via sysfs, which can take
> appropriate actions to mitigate the errors.
> 

..

> +
>  static void qcom_pcie_init_debugfs(struct qcom_pcie *pcie)
>  {
>  	struct dw_pcie *pci = pcie->pci;
> @@ -1496,6 +1829,21 @@ static int qcom_pcie_probe(struct platform_device *pdev)
>  		goto err_pm_runtime_put;
>  	}
>  
> +	pcie->global_irq = platform_get_irq_byname(pdev, "global");
> +	if (pcie->global_irq < 0) {
> +		ret = pcie->global_irq;
> +		goto err_pm_runtime_put;

How does this work with old DTS and with all other platforms? Was it tested?

Best regards,
Krzysztof