linux-kernel - Re: [PATCH v6 09/13] pinctrl: eyeq5: add platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZAYTSVONT90.2FE905FRDMZBV@bootlin.com>
Date: Wed, 21 Feb 2024 19:24:04 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Linus Walleij" <linus.walleij@...aro.org>
Cc: "Gregory CLEMENT" <gregory.clement@...tlin.com>, "Michael Turquette"
 <mturquette@...libre.com>, "Stephen Boyd" <sboyd@...nel.org>, "Rob Herring"
 <robh+dt@...nel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@...aro.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 Rafał Miłecki <rafal@...ecki.pl>, "Philipp Zabel"
 <p.zabel@...gutronix.de>, "Vladimir Kondratiev"
 <vladimir.kondratiev@...ileye.com>, <linux-mips@...r.kernel.org>,
 <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@...ileye.com>, <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v6 09/13] pinctrl: eyeq5: add platform driver

Hello,

On Wed Feb 21, 2024 at 2:41 PM CET, Linus Walleij wrote:
> On Mon, Feb 12, 2024 at 2:44 PM Théo Lebrun <theo.lebrun@...tlin.com> wrote:
>
> > Add the Mobileye EyeQ5 pin controller driver. It might grow to add later
> > support of other platforms from Mobileye. It belongs to a syscon region
> > called OLB.
> >
> > Existing pins and their function live statically in the driver code
> > rather than in the devicetree, see compatible match data.
> >
> > Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> > +       ret = devm_pinctrl_register_and_init(dev, &pctrl->desc, pctrl, &pctldev);
> > +       if (ret) {
> > +               dev_err(dev, "Failed registering pinctrl device: %d\n", ret);
> > +               return ret;
> > +       }
> > +
> > +       ret = pinctrl_enable(pctldev);
> > +       if (ret) {
> > +               dev_err(dev, "Failed enabling pinctrl device: %d\n", ret);
> > +               return ret;
> > +       }
>
> You could use dev_err_probe() here which suppresses -EPROBE_DEFER
> messages, but I'm not picky, just mentioning it.

Well, I've followed your suggestion in the v7 revision. Thanks!

https://lore.kernel.org/lkml/20240221-mbly-clk-v7-0-31d4ce3630c3@bootlin.com/

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com