[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZdZ8+vwoILO3pf0h@duo.ucw.cz>
Date: Wed, 21 Feb 2024 23:45:14 +0100
From: Pavel Machek <pavel@....cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: phone-devel@...r.kernel.org, kernel list <linux-kernel@...r.kernel.org>,
fiona.klute@....de, martijn@...xit.nl, samuel@...lland.org,
heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
linux-usb@...r.kernel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
megi@....cz
Subject: Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding
document
Hi!
> > + reset-gpios:
> > + maxItems: 1
>
> blank line
>
> > + avdd10-supply:
> > + description:
> > + 1.0V power supply
>
> Keep description in one line and add a blank line. This code is not that
> readable.
>
> > + i2c-supply:
> > + description:
> > + Power supply
>
> Drop all useless descriptions (so : true)
Ok, fixed, I hope I got it right.
> > + vbus-supply:
> > + description:
> > + Power supply
> > + vbus_in-supply:
>
> No underscores in property names.
Ok.
> > + connector:
> > + type: object
> > + $ref: ../connector/usb-connector.yaml
>
> Full path, so /schemas/connector/......
>
> > + unevaluatedProperties: false
>
> Drop
> > +
> > + description:
> > + Properties for usb c connector.
>
> > +
> > + properties:
> > + compatible:
> > + const: usb-c-connector
> > +
> > + power-role: true
> > +
> > + data-role: true
> > +
> > + try-power-role: true
>
> I don't understand why do you have here properties. Do you see any
> binding like this?
Well, it looks like I copied these mistakes from analogix,anx7411.yaml .
> > +
> > + required:
> > + - compatible
>
> Drop, why is it needed?
Again, copy from analogix,anx7411.yaml .
Should I try to fix up analogix,anx7411.yaml , and submit that, first,
or is it easier if you do that?
Thanks and best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists