linux-kernel - Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2bba1fd-bda3-4dc1-a62a-b3d1039926b3@linaro.org>
Date: Thu, 22 Feb 2024 09:22:46 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Pavel Machek <pavel@....cz>
Cc: phone-devel@...r.kernel.org, kernel list <linux-kernel@...r.kernel.org>,
 fiona.klute@....de, martijn@...xit.nl, samuel@...lland.org,
 heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
 linux-usb@...r.kernel.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org, megi@....cz
Subject: Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding
 document

On 21/02/2024 23:45, Pavel Machek wrote:
>>> +    properties:
>>> +      compatible:
>>> +        const: usb-c-connector
>>> +
>>> +      power-role: true
>>> +
>>> +      data-role: true
>>> +
>>> +      try-power-role: true
>>
>> I don't understand why do you have here properties. Do you see any
>> binding like this?
> 
> Well, it looks like I copied these mistakes from analogix,anx7411.yaml .
> 
>>> +
>>> +    required:
>>> +      - compatible
>>
>> Drop, why is it needed?
> 
> Again, copy from analogix,anx7411.yaml .
> 
> Should I try to fix up analogix,anx7411.yaml , and submit that, first,
> or is it easier if you do that?

I'll fix it up, thanks.

Best regards,
Krzysztof