linux-kernel - Re: [PATCH v2] interconnect: constify of_phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c4bdd9f-6b1f-43a0-9baa-7c1eedd46f76@linaro.org>
Date: Wed, 21 Feb 2024 08:13:46 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alim Akhtar <alim.akhtar@...sung.com>, 'Georgi Djakov'
 <djakov@...nel.org>, 'Bjorn Andersson' <andersson@...nel.org>,
 'Konrad Dybcio' <konrad.dybcio@...aro.org>,
 'Sylwester Nawrocki' <s.nawrocki@...sung.com>,
 'Artur Świgoń' <a.swigon@...sung.com>,
 'Thierry Reding' <thierry.reding@...il.com>,
 'Jonathan Hunter' <jonathanh@...dia.com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-tegra@...r.kernel.org
Cc: 'Thierry Reding' <treding@...dia.com>
Subject: Re: [PATCH v2] interconnect: constify of_phandle_args in xlate

On 20/02/2024 13:18, Alim Akhtar wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Sent: Tuesday, February 20, 2024 12:52 PM
>> To: Georgi Djakov <djakov@...nel.org>; Bjorn Andersson
>> <andersson@...nel.org>; Konrad Dybcio <konrad.dybcio@...aro.org>;
>> Sylwester Nawrocki <s.nawrocki@...sung.com>; Artur Świgoń
>> <a.swigon@...sung.com>; Krzysztof Kozlowski
>> <krzysztof.kozlowski@...aro.org>; Alim Akhtar
>> <alim.akhtar@...sung.com>; Thierry Reding <thierry.reding@...il.com>;
>> Jonathan Hunter <jonathanh@...dia.com>; linux-pm@...r.kernel.org;
>> linux-kernel@...r.kernel.org; linux-arm-msm@...r.kernel.org; linux-
>> samsung-soc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
>> tegra@...r.kernel.org
>> Cc: Thierry Reding <treding@...dia.com>
>> Subject: [PATCH v2] interconnect: constify of_phandle_args in xlate
>>
>> The xlate callbacks are supposed to translate of_phandle_args to proper
>> provider without modifying the of_phandle_args.  Make the argument
>> pointer to const for code safety and readability.
>>
>> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> Acked-by: Thierry Reding <treding@...dia.com> # Tegra
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> ---
>>
>> Changes in v2:
>> 1. Drop unrelated gpiolib changes (Konrad, Thierry).
>> 2. Add tags.
>> ---
>>  drivers/interconnect/core.c            |  4 ++--
>>  drivers/interconnect/qcom/icc-common.c |  3 ++-
>> drivers/interconnect/qcom/icc-common.h |  3 ++-
>> drivers/interconnect/samsung/exynos.c  |  2 +-
>>  drivers/memory/tegra/mc.c              |  2 +-
>>  drivers/memory/tegra/tegra124-emc.c    |  2 +-
>>  drivers/memory/tegra/tegra124.c        |  2 +-
>>  drivers/memory/tegra/tegra186-emc.c    |  2 +-
>>  drivers/memory/tegra/tegra20-emc.c     |  2 +-
>>  drivers/memory/tegra/tegra20.c         |  2 +-
>>  drivers/memory/tegra/tegra30-emc.c     |  2 +-
>>  drivers/memory/tegra/tegra30.c         |  2 +-
>>  include/linux/interconnect-provider.h  | 11 ++++++-----
>>  include/soc/tegra/mc.h                 |  7 ++++---
>>  14 files changed, 25 insertions(+), 21 deletions(-)
>>
> 
> For Samsung/Exynos
> Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

Review tags are per patch. You probably meant Acked-by.
https://elixir.bootlin.com/linux/v6.8-rc5/source/Documentation/process/submitting-patches.rst#L544

What is there anyway to review in Samsung? Adding one const in one driver?


Best regards,
Krzysztof