linux-kernel - RE: [PATCH v2] interconnect: constify of_phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 15:58:38 +0530
From: "Alim Akhtar" <alim.akhtar@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>, "'Georgi
 Djakov'" <djakov@...nel.org>, "'Bjorn Andersson'" <andersson@...nel.org>,
	"'Konrad	Dybcio'" <konrad.dybcio@...aro.org>, "'Sylwester Nawrocki'"
	<s.nawrocki@...sung.com>, 'Artur Świgoń'
	<a.swigon@...sung.com>, "'Thierry Reding'" <thierry.reding@...il.com>,
	"'Jonathan Hunter'" <jonathanh@...dia.com>, <linux-pm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-tegra@...r.kernel.org>
Cc: "'Thierry Reding'" <treding@...dia.com>
Subject: RE: [PATCH v2] interconnect: constify of_phandle_args in xlate

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, February 21, 2024 12:44 PM
> To: Alim Akhtar <alim.akhtar@...sung.com>; 'Georgi Djakov'
> <djakov@...nel.org>; 'Bjorn Andersson' <andersson@...nel.org>; 'Konrad
> Dybcio' <konrad.dybcio@...aro.org>; 'Sylwester Nawrocki'
> <s.nawrocki@...sung.com>; 'Artur Świgoń' <a.swigon@...sung.com>;
> 'Thierry Reding' <thierry.reding@...il.com>; 'Jonathan Hunter'
> <jonathanh@...dia.com>; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-msm@...r.kernel.org; linux-samsung-
> soc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> tegra@...r.kernel.org
> Cc: 'Thierry Reding' <treding@...dia.com>
> Subject: Re: [PATCH v2] interconnect: constify of_phandle_args in xlate
> 
> On 20/02/2024 13:18, Alim Akhtar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Tuesday, February 20, 2024 12:52 PM
> >> To: Georgi Djakov <djakov@...nel.org>; Bjorn Andersson
> >> <andersson@...nel.org>; Konrad Dybcio <konrad.dybcio@...aro.org>;
> >> Sylwester Nawrocki <s.nawrocki@...sung.com>; Artur Świgoń
> >> <a.swigon@...sung.com>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski@...aro.org>; Alim Akhtar
> >> <alim.akhtar@...sung.com>; Thierry Reding
> <thierry.reding@...il.com>;
> >> Jonathan Hunter <jonathanh@...dia.com>; linux-pm@...r.kernel.org;
> >> linux-kernel@...r.kernel.org; linux-arm-msm@...r.kernel.org; linux-
> >> samsung-soc@...r.kernel.org; linux-arm-kernel@...ts.infradeadorg;
> >> linux- tegra@...r.kernel.org
> >> Cc: Thierry Reding <treding@...dia.com>
> >> Subject: [PATCH v2] interconnect: constify of_phandle_args in xlate
> >>
> >> The xlate callbacks are supposed to translate of_phandle_args to
> >> proper provider without modifying the of_phandle_args.  Make the
> >> argument pointer to const for code safety and readability.
> >>
> >> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> >> Acked-by: Thierry Reding <treding@...dia.com> # Tegra
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>
> >> ---
> >>
> >> Changes in v2:
> >> 1. Drop unrelated gpiolib changes (Konrad, Thierry).
> >> 2. Add tags.
> >> ---
> >>  drivers/interconnect/core.c            |  4 ++--
> >>  drivers/interconnect/qcom/icc-common.c |  3 ++-
> >> drivers/interconnect/qcom/icc-common.h |  3 ++-
> >> drivers/interconnect/samsung/exynos.c  |  2 +-
> >>  drivers/memory/tegra/mc.c              |  2 +-
> >>  drivers/memory/tegra/tegra124-emc.c    |  2 +-
> >>  drivers/memory/tegra/tegra124.c        |  2 +-
> >>  drivers/memory/tegra/tegra186-emc.c    |  2 +-
> >>  drivers/memory/tegra/tegra20-emc.c     |  2 +-
> >>  drivers/memory/tegra/tegra20.c         |  2 +-
> >>  drivers/memory/tegra/tegra30-emc.c     |  2 +-
> >>  drivers/memory/tegra/tegra30.c         |  2 +-
> >>  include/linux/interconnect-provider.h  | 11 ++++++-----
> >>  include/soc/tegra/mc.h                 |  7 ++++---
> >>  14 files changed, 25 insertions(+), 21 deletions(-)
> >>
> >
> > For Samsung/Exynos
> > Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>
> 
> Review tags are per patch. You probably meant Acked-by.
if that is more appropriate in this case, feel free to add
Acked-by: Alim Akhtar <alim.akhtar@...sung.com>

> https://protect2.fireeye.com/v1/url?k=bc64ffdb-ddefeaed-bc657494-
> 74fe485cbff1-62590d464cd6269e&q=1&e=ec8047f9-eeac-446c-8ba5-
> 476f581d9cfa&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.8-
> rc5%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
> patches.rst%23L544
> 
> What is there anyway to review in Samsung? Adding one const in one driver?
> 
I my opinion, any changes coming in, has to be reviewed to see if there is/are any side effect because of the change,
even though the changes looks trivial.

> 
> Best regards,
> Krzysztof