[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZdemsdGQE0RtilCd@shikoro>
Date: Thu, 22 Feb 2024 20:55:29 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Rob Herring <robh@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Andi Shyti <andi.shyti@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-i3c@...ts.infradead.org,
linux-sound@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: Remove obsolete i2c.txt
On Thu, Feb 22, 2024 at 10:43:42AM -0700, Rob Herring wrote:
> Everything in i2c.txt is covered by schemas/i2c/i2c-controller.yaml in
> dtschema project, so remove i2c.txt and update links to it in the tree.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
Differences to i2c.txt:
* In the schema, "clock-frequency" has a minimum of 1kHz and a maximum
of 3MHz. Why? The specs do not say anything about a minimum freq and
fastest speed mentioned in the docs is 5Mhz (Ultra fast mode).
* new binding "i2c-scl-clk-low-timeout-us" has a description which I do
not understand. What is a waiting state?
* new binding "no-detect" is broken. At the least, it should be named
something like "bus-fully-described" and then the OS can decide to
leave out auto-detection mechanisms. If you are interested in the
latter, you can simply disable class based instantiation on the host
controller. No need to describe this in DT.
> Wolfram, you can take it or I can.
Once we are done, I guess it is better if you take it.
Thanks for the work,
Wolfram
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists