linux-kernel - Re: [PATCH] dt-bindings: i2c: Remove obsolete i2c.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 09:55:40 -0700
From: Rob Herring <robh@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, Rob Herring <robh@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andi Shyti <andi.shyti@...nel.org>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Miquel Raynal <miquel.raynal@...tlin.com>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org, 
	linux-i3c@...ts.infradead.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: Remove obsolete i2c.txt

On Thu, Feb 22, 2024 at 12:55 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
>
> On Thu, Feb 22, 2024 at 10:43:42AM -0700, Rob Herring wrote:
> > Everything in i2c.txt is covered by schemas/i2c/i2c-controller.yaml in
> > dtschema project, so remove i2c.txt and update links to it in the tree.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
>
> Differences to i2c.txt:

Thanks

> * In the schema, "clock-frequency" has a minimum of 1kHz and a maximum
>   of 3MHz. Why? The specs do not say anything about a minimum freq and
>   fastest speed mentioned in the docs is 5Mhz (Ultra fast mode).

IIRC, the high speed mode originally topped out at 3MHz. I guess
that's been revised.

We can drop the minimum.

> * new binding "i2c-scl-clk-low-timeout-us" has a description which I do
>   not understand. What is a waiting state?

Shrug. May have to look at the MPC h/w that uses the property.

>
> * new binding "no-detect" is broken. At the least, it should be named
>   something like "bus-fully-described" and then the OS can decide to
>   leave out auto-detection mechanisms. If you are interested in the
>   latter, you can simply disable class based instantiation on the host
>   controller. No need to describe this in DT.

I've reverted the property now.

Rob