linux-kernel - Re: [PATCH] mm: userfaultfd: fix unexpected change to src_folio when UFFDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240222130005.c3f24eed1c1a27c66947e9df@linux-foundation.org>
Date: Thu, 22 Feb 2024 13:00:05 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: aarcange@...hat.com, surenb@...gle.com, david@...hat.com,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: userfaultfd: fix unexpected change to src_folio
 when UFFDIO_MOVE fails

On Thu, 22 Feb 2024 16:08:15 +0800 Qi Zheng <zhengqi.arch@...edance.com> wrote:

> After ptep_clear_flush(), if we find that src_folio is pinned we will fail
> UFFDIO_MOVE and put src_folio back to src_pte entry, but the change to
> src_folio->{mapping,index} is not restored in this process. This is not
> what we expected, so fix it.
> 
> Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI")

What are the expected worst-case userspace-visible runtime effects of
this flaw?