[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zdb-EHnTiez6KP-K@pengutronix.de>
Date: Thu, 22 Feb 2024 08:56:00 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
Corey Minyard <minyard@....org>,
Andrew Manley <andrew.manley@...lingtech.com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: imx: when being a target, mark the last read as
processed
Hi Wolfram,
On Wed, Feb 21, 2024 at 11:54:54PM +0100, Wolfram Sang wrote:
> On Wed, Feb 21, 2024 at 09:58:23PM +0100, Andi Shyti wrote:
> > Hi Wolfram and Corey,
> >
> > On Wed, Feb 21, 2024 at 08:27:13PM +0100, Wolfram Sang wrote:
> > > From: Corey Minyard <minyard@....org>
> > >
> > > When being a target, NAK from the controller means that all bytes have
> > > been transferred. So, the last byte needs also to be marked as
> > > 'processed'. Otherwise index registers of backends may not increase.
> > >
> > > Signed-off-by: Corey Minyard <minyard@....org>
> > > Tested-by: Andrew Manley <andrew.manley@...lingtech.com>
> > > Reviewed-by: Andrew Manley <andrew.manley@...lingtech.com>
> > > Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > > [wsa: fixed comment and commit message to properly describe the case]
> > > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> >
> > is this a fix?
>
> In deed, it is:
>
> Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver")
Looks good :)
Are any action needed on my side?
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists