linux-kernel - Re: [PATCH v3] i2c: imx: when being a target, mark the last read as processed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdcAOwHWWYQZe3wE@shikoro>
Date: Thu, 22 Feb 2024 09:05:15 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
	Corey Minyard <minyard@....org>,
	Andrew Manley <andrew.manley@...lingtech.com>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	NXP Linux Team <linux-imx@....com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: imx: when being a target, mark the last read as
 processed

On Thu, Feb 22, 2024 at 08:56:00AM +0100, Oleksij Rempel wrote:

> > > > When being a target, NAK from the controller means that all bytes have
> > > > been transferred. So, the last byte needs also to be marked as
> > > > 'processed'. Otherwise index registers of backends may not increase.
> > > > 
> > > > Signed-off-by: Corey Minyard <minyard@....org>
> > > > Tested-by: Andrew Manley <andrew.manley@...lingtech.com>
> > > > Reviewed-by: Andrew Manley <andrew.manley@...lingtech.com>
> > > > Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > > > [wsa: fixed comment and commit message to properly describe the case]
> > > > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > > 
> > > is this a fix?
> > 
> > In deed, it is:
> > 
> > Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver")
> 
> Looks good :)
> Are any action needed on my side?

Nope. All tags are still valid, I'd say, because I didn't change any code.

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)