[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZddNAHqwCNR5MZc4@smile.fi.intel.com>
Date: Thu, 22 Feb 2024 15:32:48 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Saravana Kannan <saravanak@...gle.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Ard Biesheuvel <ardb@...nel.org>,
Frank Rowand <frowand.list@...il.com>,
Daniel Scally <djrscally@...il.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Len Brown <lenb@...nel.org>, kernel-team@...roid.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-efi@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v3 4/4] of: property: fw_devlink: Add support for
"post-init-providers" property
On Wed, Feb 21, 2024 at 03:30:24PM -0800, Saravana Kannan wrote:
> Add support for this property so that dependency cycles can be broken and
> fw_devlink can do better probe/suspend/resume ordering between devices in a
> dependency cycle.
..
> - fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), 0);
> + fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np),
> + flags);
I would leave it one line despite being 83 characters long.
..
> - of_link_to_phandle(con_dev_np, phandle);
> + of_link_to_phandle(con_dev_np, phandle,
> + s->fwlink_flags);
I would leave this on one line, it's only 81 characters.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists