linux-kernel - Re: [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 21:56:56 +0100
From: Pavel Machek <pavel@....cz>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Duje Mihanović <duje.mihanovic@...le.hr>,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers

Hi!

> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: added one more missing header
>  drivers/leds/leds-expresswire.c  | 4 ++++
>  include/linux/leds-expresswire.h | 4 +++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 

> diff --git a/include/linux/leds-expresswire.h b/include/linux/leds-expresswire.h
> index 3c61902ccac8..a422921f4159 100644
> --- a/include/linux/leds-expresswire.h
> +++ b/include/linux/leds-expresswire.h
> @@ -8,7 +8,9 @@
>  #ifndef _LEDS_EXPRESSWIRE_H
>  #define _LEDS_EXPRESSWIRE_H
>  
> -#include <linux/gpio/consumer.h>
> +#include <linux/types.h>
> +
> +struct gpio_desc;

If include tweak means you need to declare struct, is it ian
improvement?

BR,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)