linux-kernel - Re: [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499911fc-71fb-4ee6-a121-c8698daf31e3@skole.hr>
Date: Sat, 24 Feb 2024 16:31:12 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Pavel Machek <pavel@....cz>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
 Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers

On 2/23/2024 9:56 PM, Pavel Machek wrote:
>> -#include <linux/gpio/consumer.h>
>> +#include <linux/types.h>
>> +
>> +struct gpio_desc;
> 
> If include tweak means you need to declare struct, is it ian
> improvement?

In this case I'd say yes, the header in question has numerous other 
declarations (which are not used in leds-expresswire.h) and itself 
declares gpio_desc like this anyway.

Regards,
--
Duje