[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb4c94f5-082d-48d8-9d4c-099375603f9f@linuxfoundation.org>
Date: Fri, 23 Feb 2024 14:48:44 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Laura Nao <laura.nao@...labora.com>, ojeda@...nel.org,
alex.gaynor@...il.com, wedsonaf@...il.com, shuah@...nel.org
Cc: usama.anjum@...labora.com, a.hindborg@...sung.com, aliceryhl@...gle.com,
benno.lossin@...ton.me, bjorn3_gh@...tonmail.com, boqun.feng@...il.com,
gary@...yguo.net, kernel@...labora.com, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org, rust-for-linux@...r.kernel.org,
kernel@...entinobst.de, Sergio Gonzalez Collado <sergio.collado@...il.com>,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] kselftest: Add basic test for probing the rust sample
modules
On 2/22/24 09:29, Laura Nao wrote:
> Add new basic kselftest that checks if the available rust sample modules
> can be added and removed correctly.
>
> Signed-off-by: Laura Nao <laura.nao@...labora.com>
> Reviewed-by: Sergio Gonzalez Collado <sergio.collado@...il.com>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
> Changes in v3:
> - Removed useless KSFT_PASS, KSFT_FAIL, KSFT_SKIP constants
> - Used ktap_finished to print the results summary and handle the return code
> Changes in v2:
> - Added missing SPDX line
> - Edited test_probe_samples.sh script to use the common KTAP helpers file
> ---
> MAINTAINERS | 1 +
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/rust/Makefile | 4 +++
> .../selftests/rust/test_probe_samples.sh | 34 +++++++++++++++++++
> 4 files changed, 40 insertions(+)
> create mode 100644 tools/testing/selftests/rust/Makefile
> create mode 100755 tools/testing/selftests/rust/test_probe_samples.sh
>
Looks good to me. Don't you need a config file for this test?
Refer to config files for existing tests as a reference.
thanks,
-- Shuah
Powered by blists - more mailing lists