linux-kernel - Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170872506304.206263.3199862434632781431.b4-ty@linux.dev>
Date: Fri, 23 Feb 2024 21:51:12 +0000
From: Oliver Upton <oliver.upton@...ux.dev>
To: Oliver Upton <oliver.upton@...ux.dev>,
	kvm@...r.kernel.org
Cc: Nicholas Piggin <npiggin@...il.com>,
	kvmarm@...ts.linux.dev,
	aneesh.kumar@...nel.org,
	Sean Christopherson <seanjc@...gle.com>,
	linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>,
	Marc Zyngier <maz@...nel.org>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Sebastian Ene <sebastianene@...gle.com>,
	naveen.n.rao@...ux.ibm.com,
	Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs()

On Fri, 16 Feb 2024 15:59:41 +0000, Oliver Upton wrote:
> The general expectation with debugfs is that any initialization failure
> is nonfatal. Nevertheless, kvm_arch_create_vm_debugfs() allows
> implementations to return an error and kvm_create_vm_debugfs() allows
> that to fail VM creation.
> 
> Change to a void return to discourage architectures from making debugfs
> failures fatal for the VM. Seems like everyone already had the right
> idea, as all implementations already return 0 unconditionally.
> 
> [...]

Applied to kvmarm/next, thanks!

[1/1] KVM: Get rid of return value from kvm_arch_create_vm_debugfs()
      https://git.kernel.org/kvmarm/kvmarm/c/284851ee5cae

--
Best,
Oliver