linux-kernel - Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABgObfYZBnTjXh4TqH77HjO3zTMRfekaorTUVqQoFOMPJLjJTg@mail.gmail.com>
Date: Fri, 23 Feb 2024 16:31:55 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: kvm@...r.kernel.org, Nicholas Piggin <npiggin@...il.com>, 
	Michael Ellerman <mpe@...erman.id.au>, Christophe Leroy <christophe.leroy@...roup.eu>, 
	aneesh.kumar@...nel.org, naveen.n.rao@...ux.ibm.com, 
	Sean Christopherson <seanjc@...gle.com>, linuxppc-dev@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org, kvmarm@...ts.linux.dev, 
	Marc Zyngier <maz@...nel.org>, Sebastian Ene <sebastianene@...gle.com>
Subject: Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs()

On Fri, Feb 16, 2024 at 5:00 PM Oliver Upton <oliver.upton@...ux.dev> wrote:
>
> The general expectation with debugfs is that any initialization failure
> is nonfatal. Nevertheless, kvm_arch_create_vm_debugfs() allows
> implementations to return an error and kvm_create_vm_debugfs() allows
> that to fail VM creation.
>
> Change to a void return to discourage architectures from making debugfs
> failures fatal for the VM. Seems like everyone already had the right
> idea, as all implementations already return 0 unconditionally.
>
> Signed-off-by: Oliver Upton <oliver.upton@...ux.dev>

Acked-by: Paolo Bonzini <pbonzini@...hat.com>

Feel free to place it in kvm-arm.

Paolo