linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240223220115.GB9299@packtop>
Date: Fri, 23 Feb 2024 22:01:15 +0000
From: Zev Weiss <zweiss@...inix.com>
To: Conor Dooley <conor@...nel.org>
CC: Kelly Hung <ppighouse@...il.com>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kelly_hung@...s.com" <kelly_hung@...s.com>,
        "robh+dt@...nel.org"
	<robh+dt@...nel.org>,
        "joel@....id.au" <joel@....id.au>,
        "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
        "Allenyy_Hsu@...s.com" <Allenyy_Hsu@...s.com>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

On Thu, Feb 22, 2024 at 08:02:07AM PST, Conor Dooley wrote:
>On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote:
>> Document the new compatibles used on ASUS X4TF.
>
>It would be good to mention here what the x4tf is - is it a bmc or
>an sbc etc.
>

..and if, as a quick web search indicates is likely the case, it's a
BMC for a server (or family of servers), following the existing naming
convention with something more like "asus,x4tf-bmc" might be nice.

Also, Kelly -- when sending revised versions of patches please use the
'-v' flag to git format-patch to include a version number in the subject
line so it's clearer what's going on.  (So when posting the next version
incorporating the feedback on this one use '-v3', since this appears to
be a v2.)

Zev