linux-kernel - Re: [PATCH vRFC 3/8] treewide: rename firmware_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 07:21:31 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Mukesh Ojha <quic_mojha@...cinc.com>
Cc: mcgrof@...nel.org, russ.weight@...ux.dev, rafael@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH vRFC 3/8] treewide: rename firmware_request_platform()

On Thu, Feb 22, 2024 at 11:30:28PM +0530, Mukesh Ojha wrote:
> Rename firmware_request_platform() to request_firmware_platform()
> to be more concrete and align with the name of other request
> firmware family functions.

Sorry, but no, it should be "noun_verb" for public functions.

Yes, we mess this up a lot, but keeping the namespace this way works out
better for global symbols, so "firmware_*" is best please.

thanks,

greg k-h