linux-kernel - Re: [PATCH vRFC 5/8] firmware: Convert minor inline function to macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024022341-protrude-viewer-04a7@gregkh>
Date: Fri, 23 Feb 2024 07:22:18 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Mukesh Ojha <quic_mojha@...cinc.com>
Cc: mcgrof@...nel.org, russ.weight@...ux.dev, rafael@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH vRFC 5/8] firmware: Convert minor inline function to macro

On Thu, Feb 22, 2024 at 11:30:30PM +0530, Mukesh Ojha wrote:
> Convert to_fw_priv() inline function to macro.

Why?

> No functional change.

You lost good error messages if you pass in the wrong pointer :(

There is a good reason to convert this type of function to a macro, but
you aren't using that here, so I'm not going to tell you why it would be
ok :)

thanks,

greg k-h