lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e93048e64c3f8aa2731575d4b296c473e8dadb82.camel@microchip.com>
Date: Fri, 23 Feb 2024 09:21:27 +0000
From: <Rengarajan.S@...rochip.com>
To: <jirislaby@...nel.org>, <linux-serial@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <UNGLinuxDriver@...rochip.com>,
	<Kumaravel.Thiagarajan@...rochip.com>, <linux-kernel@...r.kernel.org>,
	<Tharunkumar.Pasumarthi@...rochip.com>
Subject: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code
 to use pre-existing APIs

On Fri, 2024-02-23 at 07:08 +0100, Jiri Slaby wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On 22. 02. 24, 14:49, Rengarajan S wrote:
> > Updated the TX Burst implementation by changing the circular buffer
> > processing with the pre-existing APIs in kernel. Also updated
> > conditional
> > statements and alignment issues for better readability.
> 
> Hi,
> 
> so why are you keeping the nested double loop?
> 

Hi, in order to differentiate Burst mode handling with byte mode had
seperate loops for both. Since, having single while loop also does not
align with rx implementation (where we have seperate handling for burst
and byte) have retained the double loop. 

> --
> js
> suse labs
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ