linux-kernel - Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <276f34802a7066ea5159e7214814fb8f78a0e4ab.camel@microchip.com>
Date: Fri, 23 Feb 2024 09:22:55 +0000
From: <Rengarajan.S@...rochip.com>
To: <ilpo.jarvinen@...ux.intel.com>
CC: <jirislaby@...nel.org>, <linux-serial@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <UNGLinuxDriver@...rochip.com>,
	<Kumaravel.Thiagarajan@...rochip.com>, <linux-kernel@...r.kernel.org>,
	<Tharunkumar.Pasumarthi@...rochip.com>
Subject: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code
 to use pre-existing APIs

On Thu, 2024-02-22 at 18:01 +0200, Ilpo Järvinen wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Thu, 22 Feb 2024, Rengarajan S wrote:
> 
> > Updated the TX Burst implementation by changing the circular buffer
> > processing with the pre-existing APIs in kernel. Also updated
> > conditional
> > statements and alignment issues for better readability.
> > 
> > Signed-off-by: Rengarajan S <rengarajan.s@...rochip.com>
> > ---
> 
> > @@ -434,16 +435,7 @@ static void pci1xxxx_tx_burst(struct uart_port
> > *port, u32 uart_status)
> > 
> >       xmit = &port->state->xmit;
> > 
> > -     if (port->x_char) {
> > -             writeb(port->x_char, port->membase + UART_TX);
> > -             port->icount.tx++;
> > -             port->x_char = 0;
> > -             return;
> > -     }
> > -
> > -     if ((uart_tx_stopped(port)) || (uart_circ_empty(xmit))) {
> > -             port->ops->stop_tx(port);
> > -     } else {
> > +     if (!(port->x_char)) {
> >               data_empty_count = (pci1xxxx_read_burst_status(port)
> > &
> >                                   UART_BST_STAT_TX_COUNT_MASK) >>
> > 8;
> >               do {
> > @@ -453,15 +445,22 @@ static void pci1xxxx_tx_burst(struct
> > uart_port *port, u32 uart_status)
> >                                                  
> > &data_empty_count,
> >                                                  
> > &valid_byte_count);
> > 
> > -                     port->icount.tx++;
> >                       if (uart_circ_empty(xmit))
> >                               break;
> >               } while (data_empty_count && valid_byte_count);
> > +     } else {
> > +             writeb(port->x_char, port->membase + UART_TX);
> > +             port->icount.tx++;
> > +             port->x_char = 0;
> > +             return;
> 
> Why you made this reorganization for x_char handling?? It seems
> entirely wrong thing to do, x_char should have precendence over
> sending normal chars.
> 
> This patch would have been some much simpler to review if it would
> have
> not attempted to n things in one go, please try to split into
> sensible
> changes.
> 

Hi, Thanks for reviewing the patch. Will address the comments and share
the updated patch shortly.

> 
> --
>  i.
>