linux-kernel - Re: [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240223102814.GN10170@google.com>
Date: Fri, 23 Feb 2024 10:28:14 +0000
From: Lee Jones <lee@...nel.org>
To: Pavel Machek <pavel@....cz>
Cc: Aren Moynihan <aren@...cevolution.org>, linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
	Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
	Chen-Yu Tsai <wens@...e.org>, Ondrej Jirman <megi@....cz>,
	linux-sunxi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	linux-leds@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
	Miles Alan <m@...esalan.com>, Samuel Holland <samuel@...lland.org>
Subject: Re: [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to
 stay on in suspend

On Thu, 22 Feb 2024, Pavel Machek wrote:

> Hi!
> 
> > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we
> > shouldn't need to set it here. This makes it possible to use multicolor
> > groups with gpio leds that enable retain-state-suspended in the device
> > tree.
> > 
> > Signed-off-by: Aren Moynihan <aren@...cevolution.org>
> 
> Thanks for the series.
> 
> Acked-by: Pavel Machek <pavel@....cz>
> 
> Note this will change userland API and maybe break the LED for code
> expecting old setup and hardcoding paths. I guess we should not
> backport this to stable. But we should do this, because it is really
> one LED and not three.

Thanks Pavel.

Is this tied to the other patches in the set?

Will thing break if this is applied on its own?

-- 
Lee Jones [李琼斯]