linux-kernel - Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240223102914.GO10170@google.com>
Date: Fri, 23 Feb 2024 10:29:14 +0000
From: Lee Jones <lee@...nel.org>
To: Jernej Škrabec <jernej.skrabec@...il.com>
Cc: linux-kernel@...r.kernel.org, Aren Moynihan <aren@...cevolution.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
	Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
	Chen-Yu Tsai <wens@...e.org>, Ondrej Jirman <megi@....cz>,
	linux-sunxi@...ts.linux.dev, Pavel Machek <pavel@....cz>,
	linux-arm-kernel@...ts.infradead.org, linux-leds@...r.kernel.org,
	Conor Dooley <conor+dt@...nel.org>, Miles Alan <m@...esalan.com>,
	Samuel Holland <samuel@...lland.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type
 to status

On Thu, 22 Feb 2024, Jernej Škrabec wrote:

> Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a):
> > The status function is described in the documentation as being a rgb led
> > used for system notifications on phones[1][2]. This is exactly what this
> > led is used for on the PinePhone, so using status is probably more
> > accurate than indicator.
> > 
> > 1: Documentation/leds/well-known-leds.txt
> > 2: include/dt-bindings/leds/common.h
> > 
> > Signed-off-by: Aren Moynihan <aren@...cevolution.org>
> 
> Sorry for late review.
> 
> Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:"
> use "allwinner: pinephone:" (check commit history of sun50i-a64-pinephone.dtsi).
> Also rgb -> RGB, led -> LED. Last, please reword commit message to exclude
> links and just say DT bindings documentation.
> 
> Note that I'll merge patches 2-3 once patch 1 is merged.

Works for me - I'll go apply it now.

-- 
Lee Jones [李琼斯]