linux-kernel - Re: [PATCH 5/6] sparc32: Do not select GENERIC_ISA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 24 Feb 2024 02:55:01 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Sam Ravnborg <sam@...nborg.org>
cc: Miquel Raynal <miquel.raynal@...tlin.com>, sparclinux@...r.kernel.org, 
    linux-parport@...ts.infradead.org, "David S. Miller" <davem@...emloft.net>, 
    Andreas Larsson <andreas@...sler.com>, 
    Randy Dunlap <rdunlap@...radead.org>, Arnd Bergmann <arnd@...db.de>, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] sparc32: Do not select GENERIC_ISA_DMA

On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote:

> sparc32 do not support generic isa dma, so do not select the symbol.
> Without this fix, the following patch would break the build with a
> missing prototype.

 Not according to my observations, kernel/dma.c is always built for 
GENERIC_ISA_DMA configurations, so:

kernel/dma.c:70:5: error: no previous prototype for 'request_dma' [-Werror=missing-prototypes]
   70 | int request_dma(unsigned int dmanr, const char * device_id)
      |     ^~~~~~~~~~~
kernel/dma.c:88:6: error: no previous prototype for 'free_dma' [-Werror=missing-prototypes]
   88 | void free_dma(unsigned int dmanr)
      |      ^~~~~~~~

are issued regardless (and FAOD with PARPORT_PC unset).

 I can't speak for SPARC support for ISA DMA, but it seems to me like the 
second sentence would best be removed, as would the Fixes: tag (in favour 
to:

Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")

I presume), and possibly the messages quoted above included instead.

  Maciej