lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.21.2402240248560.61493@angie.orcam.me.uk>
Date: Sat, 24 Feb 2024 02:54:28 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Sam Ravnborg <sam@...nborg.org>
cc: Miquel Raynal <miquel.raynal@...tlin.com>, sparclinux@...r.kernel.org, 
    linux-parport@...ts.infradead.org, "David S. Miller" <davem@...emloft.net>, 
    Andreas Larsson <andreas@...sler.com>, 
    Randy Dunlap <rdunlap@...radead.org>, Arnd Bergmann <arnd@...db.de>, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] sparc32: Use generic cmpdi2/ucmpdi2 variants

On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote:

> Use the generic variants - the implementation is the same.
> As a nice side-effect fix the following warnings:
> 
> cmpdi2.c: warning: no previous prototype for '__cmpdi2' [-Wmissing-prototypes]
> ucmpdi2.c: warning: no previous prototype for '__ucmpdi2' [-Wmissing-prototypes]
> 
> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Andreas Larsson <andreas@...sler.com>
> ---

 LGTM.  You may wish to add:

Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")

but otherwise:

Reviewed-by: Maciej W. Rozycki <macro@...am.me.uk>
Tested-by: Maciej W. Rozycki <macro@...am.me.uk> # build-tested

  Maciej

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ