linux-kernel - Re: [PATCH 1/1] x86/split_lock: add the source of exception to warning logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8367be41-c4f1-f82d-7490-c83647de7a30@oracle.com>
Date: Fri, 23 Feb 2024 19:19:29 -0800
From: Dongli Zhang <dongli.zhang@...cle.com>
To: Dave Hansen <dave.hansen@...el.com>, x86@...nel.org
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com,
        linux-kernel@...r.kernel.org, joe.jin@...cle.com
Subject: Re: [PATCH 1/1] x86/split_lock: add the source of exception to
 warning logs

Hi Dave,

On 2/23/24 08:27, Dave Hansen wrote:
> On 2/23/24 01:47, Dongli Zhang wrote:
>> @@ -1194,11 +1195,11 @@ static void split_lock_warn(unsigned long ip)
>>  bool handle_guest_split_lock(unsigned long ip)
>>  {
>>  	if (sld_state == sld_warn) {
>> -		split_lock_warn(ip);
>> +		split_lock_warn(ip, true);
>>  		return true;
>>  	}
> 
> I really despise random true/falses getting passed to functions.
> 
> Wouldn't this be a lot easier to read if you just passed the string in:
> 
> 	split_lock_warn(ip, "guest");
> 
> rather than bools plus the ternary form dance?

Thank you very much!

I will send v2 after waiting if there is no further comment.

Dongli Zhang