linux-kernel - Re: [PATCH] fat: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87msrpaf9x.fsf@mail.parknet.co.jp>
Date: Sun, 25 Feb 2024 03:27:54 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: chengming.zhou@...ux.dev, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        vbabka@...e.cz, roman.gushchin@...ux.dev, Xiongwei.Song@...driver.com,
        Chengming Zhou
 <zhouchengming@...edance.com>
Subject: Re: [PATCH] fat: remove SLAB_MEM_SPREAD flag usage

chengming.zhou@...ux.dev writes:

> From: Chengming Zhou <zhouchengming@...edance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Thanks.

> ---
>  fs/fat/cache.c | 2 +-
>  fs/fat/inode.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 738e427e2d21..2af424e200b3 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -47,7 +47,7 @@ int __init fat_cache_init(void)
>  {
>  	fat_cache_cachep = kmem_cache_create("fat_cache",
>  				sizeof(struct fat_cache),
> -				0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
> +				0, SLAB_RECLAIM_ACCOUNT,
>  				init_once);
>  	if (fat_cache_cachep == NULL)
>  		return -ENOMEM;
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5c813696d1ff..d9e6fbb6f246 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -787,7 +787,7 @@ static int __init fat_init_inodecache(void)
>  	fat_inode_cachep = kmem_cache_create("fat_inode_cache",
>  					     sizeof(struct msdos_inode_info),
>  					     0, (SLAB_RECLAIM_ACCOUNT|
> -						SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +						SLAB_ACCOUNT),
>  					     init_once);
>  	if (fat_inode_cachep == NULL)
>  		return -ENOMEM;

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>