linux-kernel - Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240224182950.1d00dab7@jic23-huawei>
Date: Sat, 24 Feb 2024 18:29:50 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Dumitru Ceclan <mitrutzceclan@...il.com>, linus.walleij@...aro.org,
 brgl@...ev.pl, andy@...nel.org, linux-gpio@...r.kernel.org, Lars-Peter
 Clausen <lars@...afoo.de>, Rob Herring <robh+dt@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Michael Walle <michael@...le.cc>, Andy Shevchenko
 <andy.shevchenko@...il.com>, Arnd Bergmann <arnd@...db.de>, ChiaEn Wu
 <chiaen_wu@...htek.com>, Niklas Schnelle <schnelle@...ux.ibm.com>, Leonard
 Göhrs <l.goehrs@...gutronix.de>, Mike Looijmans
 <mike.looijmans@...ic.nl>, Haibo Chen <haibo.chen@....com>, Hugo Villeneuve
 <hvilleneuve@...onoff.com>, David Lechner <dlechner@...libre.com>, Ceclan
 Dumitru <dumitru.ceclan@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173

On Tue, 20 Feb 2024 18:52:37 +0000
Conor Dooley <conor@...nel.org> wrote:

> On Tue, Feb 20, 2024 at 11:43:38AM +0200, Dumitru Ceclan wrote:
> 
> > +  interrupts:
> > +    minItems: 1
> > +    description: |  
> 
> > +
> > +  interrupt-names:
> > +    minItems: 1
> > +    items:
> > +      - const: rdy
> > +      - const: err  
> 
> I noticed that for minItems == 1, the rdy interrupt is required and err
> is the optional one.
> 
> With that in mind, you can simplify the interrupts description so that
> it describes the interrupts separately:
> 
>   interrupts:
>     minItems:
>     items:
>       - description:
>           Ready: multiplexed with SPI data out. While SPI CS is low,
>           can be used to indicate the completion of a conversion.
> 
>       - description:
>           Error: The three error bits in the status register (ADC_ERROR, CRC_ERROR,
>           and REG_ERROR) are OR'ed, inverted, and mapped to the ERROR pin. Therefore,
>           the ERROR pin indicates that an error has occurred.
> 
> Otherwise, I think everything has been sorted out?
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

This ordering may bite us in the future. Someone will build a board
with err as only one wired. But meh, it will be a binding relaxation needed
so I'm not that bothered by that.
> 
> Cheers,
> Conor.